Removing hardcoded urls for custom build from CI #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
make sure this continues to build in travis and the autogenerated docker hub build (https://hub.docker.com/r/radanalyticsio/openshift-spark/) |
|
I added a change to .travis.yml to fix that |
|
what about the docker hub autobuilds? maybe you can default the --build-args? |
|
Good point! I'll add a default which is going to be the original url we put in there originally. |
…not provided as build args
|
ok, be sure to revert the .travis.yml so travis builds essentially the same way docker hub will |
|
Good point. I've reverted and committed.
…On Wed, Feb 1, 2017 at 8:23 PM, Matthew Farrellee ***@***.***> wrote:
ok, be sure to revert the .travis.yml so travis builds essentially the
same way docker hub will
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABNf_3cXXdRFUyZ5-XfzbrVfixGCWfUAks5rYTAtgaJpZM4L0M1j>
.
|
mattf
suggested changes
Feb 2, 2017
.travis.yml
Outdated
| @@ -6,4 +6,4 @@ services: | |||
| - docker | |||
|
|
|||
| script: | |||
| - make build | |||
| - make build | |||
|
@mattf I've reverted travis.yml . |
mattf
approved these changes
Feb 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using customer build args we can do custom builds